[Sample] [Graphics] - Implementation of "Displaying UltraHDR (Fresco) & (Coil)"#86
Merged
[Sample] [Graphics] - Implementation of "Displaying UltraHDR (Fresco) & (Coil)"#86
Conversation
madebymozart
added
the
new sample
madebymozart
changed the title
yrezgui
requested changes
Sep 4, 2023
Contributor
yrezgui
left a comment
yrezgui
left a comment
There was a problem hiding this comment.
Could you use the existing Glide fragment? With a button, you can switch between libraries. It will reduce maintenance burden
Contributor
Author
|
This makes sense, will do so! |
yrezgui
requested changes
Sep 26, 2023
samples/README.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Available Samples | |||
|
|
|||
| - [](user-interface/predictiveback/src/main/java/com/example/platform/ui/predictiveback/PBHostingActivity.kt): | |||
Contributor
There was a problem hiding this comment.
Remove this line as it's not part of this PR
| documentation = "https://github.com/bumptech/glide", | ||
| tags = ["UltraHDR"], | ||
| ) | ||
| @RequiresApi(VERSION_CODES.UPSIDE_DOWN_CAKE) |
Contributor
There was a problem hiding this comment.
Isn't Ultra HDR support backported through libraries?
Contributor
Author
There was a problem hiding this comment.
It's not, UltraHDR the format is backwards compatible, but high brightness mode is new to API 34
Co-authored-by: Yacine Rezgui <rezgui.y@gmail.com>
madebymozart
force-pushed
the
ultrahdr-using-fresco-and-coil
branch
from
36e5b5b to
9f2dab5
Compare
yrezgui
approved these changes
Oct 17, 2023
yrezgui
added a commit
that referenced
this pull request
Dec 7, 2023
… & (Coil)" (#86) * Create Fresco & Coil Samples For displaying UltraHDR * Update to code to combine into 1 sample * Update samples/README.md --------- Co-authored-by: Yacine Rezgui <rezgui.y@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This CL contains sample code for Displaying UltraHDR using the Fresco Image Library & Coil Image Library.
Fresco - Using the
ImagePipelineCoil - Using Coroutines &
ImageLoaderHow Has This Been Tested?
Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)
Demo